CTS: improve automatic clustering #8949
Open
+32
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
… max cap Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
…efined Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
…tering Signed-off-by: luis201420 <[email protected]>
Contributor
Author
|
I ran a CI and all the public designs passed. I am waiting for the results of the private designs. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| techChar_(techChar), | ||
| maxInternalDiameter_(10), | ||
| capPerUnit_(0.0), | ||
| use_max_diameter_((HTree->getTreeType() == TreeType::MacroTree) |
Contributor
There was a problem hiding this comment.
warning: no header providing "cts::TreeType" is directly included [misc-include-cleaner]
src/cts/src/SinkClustering.cpp:14:
- #include "stt/SteinerTreeBuilder.h"
+ #include "TreeBuilder.h"
+ #include "stt/SteinerTreeBuilder.h"
arthurjolo
approved these changes
Dec 3, 2025
| const double capCost, | ||
| const unsigned sizeLimit) | ||
| { | ||
| if (useMaxCapLimit_) { |
Contributor
There was a problem hiding this comment.
I think this if statement can be a bit different now that we define when to use each of the limits.
suggestion:
bool is_limit_exceeded = false
if (useMaxCapLimit_) {
is_limit_exceeded |= (capCost > options_->getSinkBufferInputCap() * max_cap__factor_);
// size is defined by the user
if (use_max_size_) {
is_limit_exceeded |= (size >= sizeLimit);
}
// diameter is defined by the user
if (use_max_diameter_) {
is_limit_exceeded |= (cost > maxInternalDiameter_);
}
return is_limit_exceeded;
like this we don't need to separate into 2 different cases useMaxCap and not useMaxCap
arthurjolo
suggested changes
Dec 3, 2025
Comment on lines
209
to
214
| void setMaxDiameter(double distance) | ||
| { | ||
| maxDiameter_ = distance; | ||
| sinkClusteringUseMaxCap_ = false; | ||
| maxDiameterSet_ = true; | ||
| } |
Contributor
There was a problem hiding this comment.
By the comment of the PR we would only want to disable buffer max cap if both cluster size and diameter were set. But here if we set the diameter we immediately disable the useMaxCap_.
Comment on lines
223
to
228
| void setSinkClusteringSize(unsigned size) | ||
| { | ||
| sinkClustersSize_ = size; | ||
| sinkClusteringUseMaxCap_ = false; | ||
| sinkClustersSizeSet_ = true; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8540
It eliminates the need for predefined lists to find the best combination of diameter and cluster size. Both lists are no longer needed since buffer max cap includes them. The iterations that performed this search are also removed.
The following cases will now be considered as follows: