-
Notifications
You must be signed in to change notification settings - Fork 743
Add Arch Linux and Manjaro Linux support to DependencyInstaller #8609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Arch Linux and Manjaro Linux support to DependencyInstaller #8609
Conversation
- Add detection for Arch Linux and Manjaro Linux distributions - Provide instructions for installing base packages via pacman - Build common dependencies from source (cmake, bison, swig, boost, etc.) - Build or-tools 9.11 from source (no prebuilt binaries available for Arch) - Tested on Manjaro Linux with successful OpenROAD build Fixes support for Arch-based distributions that were previously unsupported.
|
Thanks for the contribution. Commits need to be signed with @sombraSoft please review as I don't know if this conflicts with your refactoring work. |
|
clang-tidy review says "All clean, LGTM! 👍" |
sombraSoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
About the refactor, I can incorporate changes from this PR into the new script after this gets merged, no problem.
I just don't have a way to test this as I don't have access to an arch or manjaro machine.
|
@Bynaryman |
maliberty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting on faith as we don't test on these platforms.
|
DCO needs to be fixed before we can merge. |
|
A timely update would be appreciated as we have a larger refactoring underway and would like to merge this first. |
Description
Adds support for Arch Linux and Manjaro Linux distributions to the dependency installer script.
Changes
etc/DependencyInstaller.shTesting
~/.localRequired System Packages
Users need to install base packages first:
Notes
_installCommonDevfunction to build dependencies from source