-
Notifications
You must be signed in to change notification settings - Fork 61
chore: updating packages, ci for 3.14 #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
WalkthroughUpdates CI to test Python 3.14 and bumps uv setup utility versions; relaxes matplotlib pin, removes gurobipy upper bound in pyproject, upgrades gurobipy in dev requirements, and scopes test warnings to specific packages. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… warnings less strict on dependencies
cc7748b to
b14de16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
🤖 Fix all issues with AI agents
In @.github/workflows/ci.yml:
- Around line 37-41: Update the uv version used in the type-check workflow to
match the test workflow: change the setup step that uses astral-sh/setup-uv@v6
(the step named "Install uv") in the type-check job from version "0.9.6" to
"0.9.26" so both jobs use version "0.9.26" (ensure the step still uses the same
python-version matrix variable `${{ matrix.python-version }}`).
- Around line 31-33: The CI matrix currently includes "python-version:
[\"3.12\", \"3.13\", \"3.14\"]" which will fail because gurobipy wheels for
cp314 are not on PyPI; add 3.14 as an allowed-failure by keeping it in the
matrix but making the job tolerate failures when matrix.python-version == '3.14'
(e.g., add a job-level continue-on-error expression like continue-on-error: ${{
matrix.python-version == '3.14' }}), so tests still run on 3.14 but won't break
the overall workflow; refer to the matrix key "python-version" and the job-level
"continue-on-error" setting and keep any gurobipy install steps unchanged.
In `@pyproject.toml`:
- Around line 128-136: The warnings-as-errors scope in pyproject.toml currently
only targets "temoa.*" and "tests.*" (the entries
"error::DeprecationWarning:temoa.*", etc.), which can hide deprecations from
upstream dependencies; update the configuration to either (a) add a separate
CI/job config that runs with broader escalation (e.g., a periodic job or new
workflow that sets warnings to error globally), or (b) extend the filters to
include specific core dependencies you care about (add additional
"error::DeprecationWarning:packagename.*" / "error::FutureWarning:packagename.*"
entries for those libraries) so that critical upstream deprecations also fail CI
while keeping day-to-day runs scoped to temoa/tests.
- Around line 67-69: The dependency constraint for the solver list currently
allows any future major gurobipy version via "gurobipy>=12.0.3"; update the
constraint to pin an upper bound to the current major to prevent breaking
changes (for example change the entry in the solver list from "gurobipy>=12.0.3"
to include an upper bound like "<13.0.0") so reinstall/CI won't pull
incompatible gurobipy majors; modify the solver array entry accordingly and run
dependency install/tests to verify compatibility.
- Around line 12-15: The pyproject dependency "matplotlib>=3.9.2" is unbounded
above and may pull meso/major releases with breaking changes; update the
constraint to include a safe upper bound (for example change "matplotlib>=3.9.2"
to "matplotlib>=3.9.2,<4.0" or "matplotlib>=3.9.2,<3.11") or add a pinned
constraints file and reference it from pyproject.toml so CI only installs vetted
matplotlib versions.
b14de16 to
b4054d7
Compare
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.