fix(utils): align Qwen tokenization for parallel tool calls#2226
Open
looput wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix groups consecutive tool messages before passing them to
apply_chat_template, preserving the formatting defined by the native Qwen2 chat template.The original issue was caused by calling
apply_chat_templateseparately for every message ingen_multi_turn_loss_mask_qwen, without preserving the context between consecutivetoolmessages.For a parallel tool-calling sequence:
The Qwen2 chat template is designed to group consecutive tool responses into a single user block:
However, the original implementation rendered each tool message independently. Since each message appeared to be both the first and last tool message, it produced:
This caused:
token_idsto differ from the native Qwen chat-template output;<|im_start|>userand<|im_end|>tokens to be inserted;The issue only affects parallel tool calling with consecutive
role="tool"responses. A single assistant message containing multipletool_calls, or sequentialassistant → tool → assistant → toolinteractions, does not trigger this problem.