-
-
Notifications
You must be signed in to change notification settings - Fork 102
Add GodotSharp to Godot #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
@akien-mga can you check if this makes any sense to use? along with #903 (I haven't checked how many games actually use these yet - the automatic check doesnt work well for godot) |
|
I'll check ASAP, but from the bot comment above, it sounds like this breaks detection of non-C# games and drop 2000 of them? Which wouldn't be right. |
|
It doesn't run the php specific checks, thats why. |
|
After running changed rules in this pull request (this bot only tests rules.ini changes): Changed technologies: Engine.Godot 3414 apps still match. These apps now match: (77) 1979980 2198350 2467050 2518740 2523390 2578830 2637050 2658560 2721710 2759640 2783730 2789810 2800490 2807580 2823840 2853180 2941400 2947470 2979620 2989400 3019910 3062500 3078000 3109580 3111100 3130160 3157900 3160450 3161730 3163870 3170220 3185150 3192920 3196110 3205350 3236360 3277500 3286850 3394530 3502520 3504220 3527340 3541180 3543590 3550060 3565570 3585830 3587210 3591910 3606900 3607200 3626120 3660450 3662060 3692480 3719900 3766920 3801150 3846990 3886480 3889530 3928030 3934540 3955180 4040980 4097050 4103990 4114390 4114490 4121250 4142580 4197530 4224510 4234610 4252500 4268360 4308230 Please confirm that all these changed apps are correct. |
akien-mga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
I confirm that this matches a number of titles not found previously, when they use the following configuration:
- Godot 3 or 4 with .NET
- "Embed PCK" option to embed the data
.pckin the.exe - No macOS build (which doesn't support "Embed PCK" as it's part of the .app already, and lets SteamDB detect it)
I checked ~30% of the new matches reported by the bot and they seem valid.
SteamDB app page links to a few games using this
https://steamdb.info/app/1979980
https://steamdb.info/app/3130160
https://steamdb.info/app/3766920
Brief explanation of the change
It's a Godot library that sometimes is used in otherwise undetected Godot games.