Skip to content

Update Godot engine detection with Godot Boy #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelHinrichs wants to merge 3 commits into from
+10 −0
Closed

Update Godot engine detection with Godot Boy #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b6001
Add Godot boy to Godot engine rules
MichaelHinrichs Sep 27, 2025
dd57a64
Add Godot boy to Engine.Godot.txt
MichaelHinrichs Sep 27, 2025
be39066
Add non-matching tests for Godot boy
MichaelHinrichs Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rules.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ GlyphX = ^ClientLauncherG(?:64)?\.exe$
Godot[] = (?:^|/)project\.godot$ ; Extra detections are in IsEngineGodot
Godot[] = (?:^|/)(?:lib)?godotsteam
Godot[] = (?:^|/)(?:lib)?steamsdk-godot
Godot[] = (?:^|/)godot_boy\.windows\.x86_64\.dll$
Godot[] = (?:^|/)libgodot_boy\.linux\.x86_64\.so$
Comment on lines +119 to +120
Copy link
Contributor

@akien-mga akien-mga Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be simplified like the above checks:

Suggested change
Godot[] = (?:^|/)godot_boy\.windows\.x86_64\.dll$
Godot[] = (?:^|/)libgodot_boy\.linux\.x86_64\.so$
Godot[] = (?:^|/)(?:lib)godot_boy

Copy link
Contributor

@akien-mga akien-mga Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said if this can use globbing it might make sense to make it more specific like:

Suggested change
Godot[] = (?:^|/)godot_boy\.windows\.x86_64\.dll$
Godot[] = (?:^|/)libgodot_boy\.linux\.x86_64\.so$
Godot[] = (?:^|/)(?:lib)godot_boy.*\.(?:dll|dylib|so)$

and likewise for godotsteam and steamsdk-godot extension libraries.

GoldSource = (?:^|Bin/)vgui\.dll$
GZDoom[] = (?:^|/)zmusic\.dll$
GZDoom[] = (?:^|/)gzdoom\.pk3$
Expand Down
4 changes: 4 additions & 0 deletions tests/types/Engine.Godot.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
/steamsdk-godot
/steamsdk-godot-test
/steamsdk-godot@
/godot_boy.windows.x86_64.dll
/libgodot_boy.linux.x86_64.so
Sub/Folder/project.godot
godotsteam
godotsteam.dll
Expand All @@ -25,3 +27,5 @@ project.godot
steamsdk-godot
steamsdk-godot.dll
steamsdk-godot@
godot_boy.windows.x86_64.dll
libgodot_boy.linux.x86_64.so
4 changes: 4 additions & 0 deletions tests/types/_NonMatchingTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1385,6 +1385,10 @@ alibsteamsdk-godot.so
agodotsteam.dll
agodotsteam.so
/agodotsteam-test
godot_boy.linux.x86_64.dll
libgodot_boy.windows.x86_64.so
godot_boy.windows.x86_64
godot_boy.linux.x86_64.so
Comment on lines +1388 to +1391
Copy link
Contributor

@akien-mga akien-mga Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my suggestion above these tests won't be non-matching anymore, but I'm not sure there's much value in testing these which should never be found in the wild (unless someone explicitly renames their libs to confuse us).

Files/languagebank/english/textfiles/fpsc-050
Files/languagebank/english/textfiles/notactuallyfpsc-050.ini
Files/languagebank/english/textfiles/fpsc-050.iniwhoops
Expand Down