Catch exception objects by const reference#160
Open
Peter-Levine wants to merge 1 commit intoSqliteModernCpp:masterfrom
Open
Catch exception objects by const reference#160Peter-Levine wants to merge 1 commit intoSqliteModernCpp:masterfrom
Peter-Levine wants to merge 1 commit intoSqliteModernCpp:masterfrom
Conversation
Collaborator
|
@Peter-Levine Thanks for the PR. I think if i merge this, then we will get conflicts with dev branch. Could you please have a look at dev branch, we definitely need to fix it. |
zauguin
added a commit
to zauguin/sqlite_modern_cpp
that referenced
this pull request
Apr 3, 2018
A version of SqliteModernCpp#160 on the `dev` branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing with latest GCC git master (8.0.1) results in errors such as:
sqlite_exceptionshould ideally be caught by reference (and, preferably, const reference) to avoid potential issues such as object slicing and memory exhaustion triggering further exceptions.