Fix multiple bugs: resource leaks, UB, logic errors, and CI fixes#252
Open
BluerCool wants to merge 4 commits into
Open
Fix multiple bugs: resource leaks, UB, logic errors, and CI fixes#252BluerCool wants to merge 4 commits into
BluerCool wants to merge 4 commits into
Conversation
…ing include, and note function trailing newline handling
BluerCool
changed the title
BluerCool
changed the title
added 3 commits
June 13, 2026 16:19
… pipe handling - Fix opendir() resource leak in generatedEntryIndex() - Fix file descriptor leak in atexit handler (utils.cpp) - Fix iterator invalidation in ignoreItemsPreemptively() and convertFromGUIClipboard() - Fix format specifier mismatch in clear.cpp (%d -> %lu) - Fix unsigned underflow in displaySearchJSON() and history entry length - Fix signed/unsigned comparison in search.cpp, formatting.cpp, history.cpp - Fix base64 out-of-bounds access in fromBase64() - Fix substring underflow in getRemoteClipboard() - Fix bitwise OR in preprocessor directive - Fix notePipe() to read note when no pipe data is available
- windows-amd64: Install openssl:x64-windows via vcpkg - windows-arm64: Add -DCMAKE_TOOLCHAIN_FILE for vcpkg integration - Both jobs now properly pass vcpkg toolchain to CMake so OpenSSL::Crypto is found
…ures - Upgrade cross-platform-actions/action from v0.13.0 to v1.2.0 - Switch to new API: use cpa.sh default shell + separate Start VM step - Update FreeBSD to 14.2, OpenBSD to 7.6, NetBSD to 10.1 - v0.13.0 had persistent SSH connection failures on newer runners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 13 bugs found through code analysis, plus CI/build fixes:
Resource leaks:
opendir()handle never closed ingeneratedEntryIndex()(clipboard.cpp)atexithandler (utils.cpp)Undefined behavior:
ignoreItemsPreemptively()andconvertFromGUIClipboard()- erasing from vector during range-for loopgetRemoteClipboard()displaySearchJSON()andhistoryentry length calculationLogic errors:
notePipe()overwrites note with empty content when run via command substitutiondisplaySearchJSON()skips first result (off-by-one)%dforunsigned longinclear.cppsearch.cpp,formatting.cpp,history.cpp|instead of logical||in preprocessorBuild/CI fixes:
All 31 integration tests pass.