Skip to content

Conversation

@H4ad
Copy link

@H4ad H4ad commented Dec 5, 2025

📄 Summary

Remove the usage of typography.text to improve performance by reducing the amount of DOM changes.


✅ Changes

  • Feature: Brief description
  • Bug fix: Brief description

🏷️ Required: Add Relevant Labels

  • frontend

👥 Reviewers

  • frontend

🧪 How to Test

  1. Open log tab
  2. Press f12, start recording performance
  3. Scroll up and down very fast

🔍 Related Issues

Reference #9784


📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)

Before:
image

After:
image


📋 Checklist

  • Dev Review
  • Test cases added (Unit/ Integration / E2E)
  • Manually tested the changes

Note

Refactors log list row rendering to use native elements with new CSS for truncation and theming, adds hover titles for full values, and removes the custom Text wrapper.

  • Frontend — Logs/ListLogView:
    • Replace Typography.Text with native elements for log field keys/values; remove Text styled component from styles.ts.
    • Add .log-text styles for truncation, min/max width, and theming (.dark/.lightMode); apply to field keys.
    • Add title attributes to show full fieldKey/fieldValue on hover.
    • Clean up imports and adjust classNames in index.tsx; keep LogText for values with optional line clamping.

Written by Cursor Bugbot for commit 01744f4. This will update automatically on new commits. Configure here.

@H4ad H4ad requested review from YounixM and aks07 as code owners December 5, 2025 02:37
@welcome
Copy link

welcome bot commented Dec 5, 2025

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on January 3

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@H4ad H4ad changed the title perf: remove typography.text that was causing style recalculation during scroll perf: remove typography.text to improve scroll performance Dec 5, 2025
max-width: 20vw;
text-overflow: ellipsis;
overflow: hidden;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing margin reset on p element causes layout issues

The .log-text class is applied to a <p> element which has default browser margins (typically margin: 1em 0), but no margin: 0 is specified in the CSS. The original Typography.Text rendered as a <span> with no default margin. Since this element is inside a flex container (TextContainer), the unwanted margin will cause vertical spacing issues and misalignment with the adjacent LogText element.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant