fix: remove key prefix when copying log body fields #9774
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| const valueStr = typeof value === 'string' ? `"${value}"` : String(value); | ||
| copyText = `"${cleanedKey}": ${valueStr}`; | ||
| const valueStr = typeof value === 'string' ? value : String(value); | ||
| copyText = valueStr; |
There was a problem hiding this comment.
Bug: Empty string values copy without showing success notification
When value is an empty string, the new code sets copyText to "" (a falsy value), causing the if (copyText) check to fail and skip the success notification. The copy operation on line 105 still executes, so the empty string is copied to the clipboard, but users won't see the "copied to clipboard" notification. Previously, copyText included the key prefix (e.g., "key": ""), which was truthy and displayed the notification correctly.
|
let's hold till we have more clarity on how should it behave for nested keys |
2 participants
📄 Summary
Updated
BodyTitleRendererto copy only field values (without keys) when clicking on fields in the log body JSON view.🔍 Related Issues
Closes https://github.com/SigNoz/engineering-pod/issues/3386
📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)
Before:
Screen.Recording.2025-12-04.102502.mp4
After:
Screen.Recording.2025-12-04.102354.mp4
📋 Checklist
👀 Notes for Reviewers
Note
Updates copy-to-clipboard to copy raw values (or pretty JSON for objects) without keys, and adjusts tests accordingly.
frontend/src/container/LogDetailedView/BodyTitleRenderer.tsxhandleNodeClickto copy only the value:JSON.stringify(value, null, 2)without the key.frontend/src/container/LogDetailedView/__tests__/BodyTitleRenderer.test.tsxWritten by Cursor Bugbot for commit dcd8b17. This will update automatically on new commits. Configure here.