Skip to content

Conversation

@SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Dec 2, 2025

📄 Summary


✅ Changes

  • Feature: Brief description
  • Bug fix: Brief description

🏷️ Required: Add Relevant Labels

⚠️ Manually add appropriate labels in the PR sidebar
Please select one or more labels (as applicable):

ex:

  • frontend
  • backend
  • devops
  • bug
  • enhancement
  • ui
  • test

👥 Reviewers

Tag the relevant teams for review:

  • frontend / backend / devops

🧪 How to Test

  1. ...
  2. ...
  3. ...

🔍 Related Issues

Closes #


📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)

Screen.Recording.2025-12-06.at.12.30.28.PM.mov

📋 Checklist

  • Dev Review
  • Test cases added (Unit/ Integration / E2E)
  • Manually tested the changes

👀 Notes for Reviewers


Note

Improves sidebar UX (hover expansion, shortcut management/persistence, refined styles), adds tooltips, tweaks dropdown behavior, updates Settings icon, and extends auto-import registry.

  • Sidebar UX/Logic:
    • Compute and sync pinned/secondary items from userPreferences to avoid initial flash; optimistic preference update on pin/reorder.
    • Change pin behavior to append items; manage "More" section state with hover/pin awareness and manual-collapse tracking.
    • Add hover-driven expansion and dropdown-open expansion (.dropdown-open), plus onOpenChange handlers for dropdowns.
    • Fix label: WHAT'S NEW.
  • Shortcuts & Tooling:
    • Add tooltips for pin/unpin and "Manage shortcuts"; reorder modal drag handling retained.
  • Styling:
    • Extensive SideNav/NavItem style updates (active/hover colors, gradients, light/dark variants, spacing, collapsed/expanded states, dropdown hover colors, secondary-items spacing).
    • Settings sidenav styles: ensure active label colors in dark/light modes.
  • Settings UI:
    • Replace header icon Wrench with Cog.
  • Misc:
    • Add @signozhq/checkbox to auto-import-registry.d.ts.

Written by Cursor Bugbot for commit a53f4e5. This will update automatically on new commits. Configure here.

@github-actions github-actions bot added docs required enhancement New feature or request labels Dec 2, 2025
@SagarRajput-7 SagarRajput-7 marked this pull request as ready for review December 3, 2025 04:43
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

setIsMoreMenuCollapsed(false);
}
prevSidebarOpenRef.current = isSidebarOpen;
}, [isPinned, isHovered]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Sidebar state reset when dropdown is open

The isSidebarOpen calculation only considers isPinned and isHovered, but doesn't include isDropdownOpen. When a dropdown is open and the mouse moves to interact with the dropdown overlay (which is outside the sidebar container), onMouseLeave fires setting isHovered to false. This causes the useEffect to treat the sidebar as collapsed, resetting userManuallyCollapsedRef to false and collapsing the more menu, even though the sidebar remains visually expanded via the CSS dropdown-open class. The isDropdownOpen state needs to be considered in the isSidebarOpen calculation.

Fix in Cursor Fix in Web

@SagarRajput-7
Copy link
Contributor Author

Found an issue, that default shortcuts are not present.

}
}

:hover,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing ampersand in SCSS hover selector

The :hover selector on line 565 is missing the & prefix. As written, :hover targets any descendant element that is being hovered, rather than the .sideNav:not(.pinned) container itself. This should likely be &:hover to match the pattern used elsewhere in the file (e.g., line 583 uses &:not(.pinned):hover). The current selector could cause hover styles to apply unexpectedly when hovering over any element inside the sidebar.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant