-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: sidebar enhancement #9748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| setIsMoreMenuCollapsed(false); | ||
| } | ||
| prevSidebarOpenRef.current = isSidebarOpen; | ||
| }, [isPinned, isHovered]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Sidebar state reset when dropdown is open
The isSidebarOpen calculation only considers isPinned and isHovered, but doesn't include isDropdownOpen. When a dropdown is open and the mouse moves to interact with the dropdown overlay (which is outside the sidebar container), onMouseLeave fires setting isHovered to false. This causes the useEffect to treat the sidebar as collapsed, resetting userManuallyCollapsedRef to false and collapsing the more menu, even though the sidebar remains visually expanded via the CSS dropdown-open class. The isDropdownOpen state needs to be considered in the isSidebarOpen calculation.
|
Found an issue, that default shortcuts are not present. |
| } | ||
| } | ||
|
|
||
| :hover, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing ampersand in SCSS hover selector
The :hover selector on line 565 is missing the & prefix. As written, :hover targets any descendant element that is being hovered, rather than the .sideNav:not(.pinned) container itself. This should likely be &:hover to match the pattern used elsewhere in the file (e.g., line 583 uses &:not(.pinned):hover). The current selector could cause hover styles to apply unexpectedly when hovering over any element inside the sidebar.
📄 Summary
✅ Changes
🏷️ Required: Add Relevant Labels
ex:
frontendbackenddevopsbugenhancementuitest👥 Reviewers
🧪 How to Test
🔍 Related Issues
Closes #
📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)
Screen.Recording.2025-12-06.at.12.30.28.PM.mov
📋 Checklist
👀 Notes for Reviewers
Note
Improves sidebar UX (hover expansion, shortcut management/persistence, refined styles), adds tooltips, tweaks dropdown behavior, updates Settings icon, and extends auto-import registry.
pinned/secondary items fromuserPreferencesto avoid initial flash; optimistic preference update on pin/reorder..dropdown-open), plusonOpenChangehandlers for dropdowns.WHAT'S NEW.SideNav/NavItemstyle updates (active/hover colors, gradients, light/dark variants, spacing, collapsed/expanded states, dropdown hover colors, secondary-items spacing).WrenchwithCog.@signozhq/checkboxtoauto-import-registry.d.ts.Written by Cursor Bugbot for commit a53f4e5. This will update automatically on new commits. Configure here.