-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: UI/UX fixes on Global Actions (CMD / CTRL + K) #9739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 3. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 3
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Removed kbar dependency still used in AppLayout
The kbar package was removed from package.json, but frontend/src/container/AppLayout/index.tsx still imports and uses useKBar from kbar (line 38: import { useKBar } from 'kbar';). This will cause a runtime error since the module no longer exists. The AppLayout component uses useKBar to manage the command palette's disabled state based on login status. This code needs to be migrated to use the new useCmdK hook from the custom provider or removed entirely.
frontend/package.json#L106-L107
Lines 106 to 107 in 11c5a16
| "jest": "^27.5.1", | |
| "js-base64": "^3.7.2", |
π Summary
Linked Issues:
β Changes
[] Feature: Added a fully customizable Cmd + K command palette. Users can quickly navigate to different parts of the application using keyboard shortcuts or by opening the palette from the left sidebar.
[] Bug Fix: Replaced the kbar library with a custom shadcn-based cmdK component published in our shared component library.
This resolves prior limitations such as:
The new implementation provides full control over styling, icons, roles (RBAC), and interactions while maintaining cleaner integration across the app.
π§ͺ How to Test
Click the search icon in the left navigation panel (below the Home icon).
This should also open the command palette.
4.Logged-out behavior: When not logged in, the command palette should not render or open via any method.
Inside the modal, clicking any command item should redirect the user to the corresponding page.
π Related Issues
Closes # #9672
Closes - #9540
πΈ Screenshots / Screen Recording (if applicable / mandatory for UI related changes)
Before:
Screen.Recording.2025-12-01.at.6.16.08.PM.mov
After
Screen.Recording.2025-12-01.at.6.17.12.PM.mov
π Checklist
π Notes for Reviewers
Note
Replaces kbar with a new
CmdKcommand palette built on@signozhq/command, wires it globally with a provider, adds a sidebar search trigger, and removes legacy kbar code/deps.components/cmdKPalette/cmdKPalette.tsxusing@signozhq/commandwith RBAC-aware actions, theme toggles, and navigation shortcuts.components/cmdKPalette/cmdKPalette.scss.providers/cmdKProvider.tsxto control open/close and globalCtrl/Cmd+Khandling.CmdKProviderand render<CmdKPalette />for logged-in users inAppRoutes/index.tsx.AppLayout.SideNav(menuItems.tsx) and handle it to open the palette (SideNav.tsx).components/cmdKPalette/__test__/cmdkPalette.test.tsx.@signozhq/commandand update auto-import registry.kbarand delete old KBar components/provider files.yarn.lockaccordingly.Written by Cursor Bugbot for commit 4bbdf72. This will update automatically on new commits. Configure here.