-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Improvement: MetricsExplorer Module suggested improvements #9730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
srikanthccv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the multiple shards query modification is still pending. will let you know when it's bumped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
@nikhilmantri0902 we're reading config from the config package. You can do: OR (Deliberately not using the word clickhouse because the abstraction is called telemetrystore)
|
|
@therealpandey made changes for config via config factory. |
📄 Summary
#7791 (comment)
✅ Changes
🏷️ Required: Add Relevant Labels
ex:
frontendbackenddevopsbugenhancementuitest👥 Reviewers
🧪 How to Test
🔍 Related Issues
Closes #
📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)
📋 Checklist
👀 Notes for Reviewers
Note
Introduces MetricsExplorer config (controls ClickHouse max_threads), renames treemap request field to
mode, sets thread limits on queries, defaults stats ordering bysamples, usesGLOBAL IN/anyLast, and requires edit access for metric metadata updates.metricsexplorerconfig withtelemetrystore.threads; wired through app init and tests.max_threadsvia context on all ClickHouse queries/inserts.GetStatsnow defaults order-by tosampleswhen unspecified.mode(fromtreemap); switch logic updated accordingly.anyLastfor metadata selection; useGLOBAL INfor candidate filtering; time conversions viaToNanoSecs./api/v2/metrics/{metric_name}/metadatanow requiresEditAccess.Written by Cursor Bugbot for commit ea5a620. This will update automatically on new commits. Configure here.