Skip to content

Conversation

@AldeRoberge
Copy link

@AldeRoberge AldeRoberge commented Mar 19, 2025

Minor typos + clearer meaning in README


Important

Fixes typos and improves clarity in README.md comparison sections with Jaeger and Loki.

  • Textual Improvements:
    • Corrects "wrt" to "than" in the comparison with Jaeger.
    • Adds missing periods at the end of bullet points in the Jaeger and Loki comparison sections for consistency.
    • Clarifies the ability to transition from traces to logs in SigNoz compared to Jaeger.

This description was created by Ellipsis for 26c4347. It will automatically update as commits are pushed.

@welcome
Copy link

welcome bot commented Mar 19, 2025

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 26c4347 in 1 minute and 0 seconds

More details
  • Looked at 29 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. README.md:180
  • Draft comment:
    Improved clarity in the Jaeger vs SigNoz comparison: bullet items now consistently end with a period. Ensure similar punctuation consistency across the document.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative and does not provide a specific code suggestion or highlight a potential issue. It also does not align with any of the additional rules provided.
2. README.md:199
  • Draft comment:
    Consistency in bullet list punctuation for the Loki vs SigNoz comparison has been addressed. Please maintain this style uniformly throughout the README.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative and does not provide a specific code suggestion or highlight a potential issue. It also does not align with any of the additional rules provided.
3. README.md:178
  • Draft comment:
    Improved clarity in the Jaeger section: replacing 'wrt' with 'than' and adding punctuation enhances readability. Also, the typo 'Jaegar' has been corrected to 'Jaeger'.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. README.md:199
  • Draft comment:
    Consistent punctuation: added a period at the end of the Loki feature description for uniformity with other statements.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
5. README.md:199
  • Draft comment:
    There's an inconsistency with the capitalization of 'Loki'. In the bullet point at line 199, 'loki' is in lowercase, whereas elsewhere it's consistently capitalized as 'Loki'. Please update it for consistency.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_2bvvsWLqTJx956mz


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv srikanthccv added the safe-to-test Run CI tests for dependabot and external contributors label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe-to-test Run CI tests for dependabot and external contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants