CI: Run on AArch64 and RISC-V in CI #26467
Open
+241
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
LucasChollet
reviewed
Dec 6, 2025
|
|
||
| Service::~Service() | ||
| { | ||
| if (m_pid == -1) |
Member
There was a problem hiding this comment.
For a multi-instance services m_pid == -1 but you will still want to remove the notifier_socker, right?
Sorry, I don't have time to look more into this right now.
Member
Author
There was a problem hiding this comment.
What do you think of this new approach of storing a SocketDescriptor::was_created flag?
Member
There was a problem hiding this comment.
I think you can use m_fd == -1 to get the same result.
Member
Author
There was a problem hiding this comment.
socket.fd is set before creating the socket file and setup_socket can still fail before running bind(), which creates the file.
nico
reviewed
Dec 6, 2025
spholz
force-pushed
the
kernel-pci-non-x86-io-bar
branch
from
dde94c9 to
e09d5c4
Compare
This mostly inserts some white space, since there currently was none.
I/O BARs are mapped to MMIO on devicetree systems.
We were previously relying on system firmware setting this command register bit.
Instead of always using PCI serial devices for console output, make them usable for other purposes by only enabling kernel log output when 'pci_serial_debug' is passed.
This if is always True since config.machine_type can't be both a Raspberry Pi machine and MachineType.CI. This code is a leftover from using the QEMU raspi3b machine in CI.
On AArch64 and RISC-V we need to use two serial ports (the built-in one and now additionally a PCI-connected one) because QEMU doesn't have something similar to the x86 isa-debugcon for these architectures.
This can happen if the service has never been started, if it is disabled.
Using remove() is unnecessary since sockets should never be directories. Also improve the debug message while here to make it clearer where this error comes from.
Similar to AArch64, multiple test currently fail on RISC-V, mostly due to inaccurate math functions. However, we still want to run RISC-V in CI to ensure that we don't break running SerenityOS on this architecture.
Running tests is still disabled until we fix all tests on these architectures.
spholz
force-pushed
the
kernel-pci-non-x86-io-bar
branch
from
e09d5c4 to
80d5847
Compare
spholz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running AArch64 in CI was previously disabled 2 years ago in d8f84ef.
AArch64 should hopefully be more stable now, so try to re-enable running AArch64 in CI.
This time using the
virtmachine instead of a RPi machine. Making our on-target test infrastructure work on this machine type required some more patches to enable PCI serial support on non-x86.Additionally, RISC-V support should now be stable enough that we can try running it CI as well.
But still don't run any tests until we fix them on these architectures.