fix(DM01-6060): use emptyDir for /root/.docker to fix docker build and login#624
Closed
liuwei08 wants to merge 3 commits into
Closed
fix(DM01-6060): use emptyDir for /root/.docker to fix docker build and login#624liuwei08 wants to merge 3 commits into
liuwei08 wants to merge 3 commits into
Conversation
…ontainer…" This reverts commit f9d79ff.
Mount docker config secret to /tmp/docker-secret (read-only) and use emptyDir for /root/.docker (writable). Copy config.json in entrypoint.sh before docker daemon starts. This fixes two issues: - docker login rename failing across devices (subPath bind mount) - docker build mkdir /root/.docker/buildx: read-only file system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #619 introduced two bugs when
docker_config_secretis set:docker loginfails with:rename /root/.docker/config.json<random> /root/.docker/config.json: device or resource busysubPathmounts the secret file as a bind mount on container rootfs (overlayfs), but docker's temp file is also on rootfs — rename crosses device boundaries with the secret tmpfs.docker buildfails with:mkdir /root/.docker/buildx: read-only file system/root/.dockermakes the whole directory read-only.Fix
/tmp/docker-secret(read-only, no conflict)emptyDirvolume mounted at/root/.docker(writable)entrypoint.sh, copy/tmp/docker-secret/config.json→/root/.docker/config.jsonbefore the docker daemon startsThis ensures:
docker logincan write/rename within the same emptyDir filesystemdocker buildcan create subdirectories under/root/.docker/