Skip to content

Conversation

@AlbinaBlazhko17
Copy link
Contributor

@AlbinaBlazhko17 AlbinaBlazhko17 commented Oct 7, 2025

What/Why/How?

We faced the issue when updating the version of openapi-core in other products. The problem was that we forgot to add new types in @redocly/config.

I created a unit test, which will fail if we forget to add types.

Reference

Discovered issue in PR #18391.

Testing

Manually.

Screenshots (optional)

Screenshot 2025-10-07 at 13 48 41

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: 5a79614

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.408 ± 0.027 1.377 1.451 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.410 ± 0.024 1.383 1.461 1.00 ± 0.03

});
});

describe('rootRedoclyConfigSchema synchronization', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reluctant to add a unit test for this here. Imagine you just want to add a property--but you wouldn't be able to do it without releasing a new config version. Can you move it to something like a smoke test (so it's not required for merging PRs)?

Copy link
Collaborator

@tatomyr tatomyr Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe term 'intergration test' is more relevant to our case though.

@AlbinaBlazhko17 AlbinaBlazhko17 self-assigned this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants