Makes all settings global #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenNneji
force-pushed
the
global_Settings
branch
from
4e336ec to
828d3d9
Compare
DrPaulSharp
reviewed
Jan 23, 2026
Collaborator
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
All looks good, but I have a question on the logging in the comments.
The "save current windows positions" option works well. I'm just wondering how intuitive it is to reset the saved positions to the tiled layout - you have to click tile windows and then the save option. Is this the best way? I'm not sure I can immediately think of something better, but it doesn't seem obvious.
| except Exception as ex: | ||
| logger = logging.getLogger("rascal_log") | ||
| logger.error("Attempted to edit a file in MATLAB engine" + repr(ex)) | ||
| logging.error("Attempted to edit a file in MATLAB engine", exc_info=ex) |
Collaborator
There was a problem hiding this comment.
Why are you switching from module level logging to using the root logger everywhere? I thought that module level logging was more advantageous.
Collaborator
There was a problem hiding this comment.
I see setup_logging modifies global settings, I think you might need to walk me through this one please.
DrPaulSharp
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Make all settings global #177
Also fixes the Windows > Save Current Windows Positions option, now if you move the mdi windows and save, the windows will be put into the same position when reopening the software or when Reset to default is clicked
Refactors logging and adds a custom stream handler so the terminal formats errors properly