-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[finsh][cmd] add 'console' command to config console #11026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-10 18:52 CST)
📝 Review Instructions
|
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
|
CI报错要解决下 |
0adc345 to
e455826
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR moves the console command from BSP-specific code to the common finsh command module, making it available across all platforms. The implementation adds support for changing the console device with proper handling for different POSIX configurations.
Key Changes:
- Added
consolecommand implementation tocomponents/finsh/cmd.cwith POSIX/POSIX_STDIO conditional compilation support - Removed duplicate
consolecommand frombsp/qemu-virt64-aarch64/applications/console.c - Added conditional include for
<posix/stdio.h>when needed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| components/finsh/cmd.c | Added console command with 'set' option to change console device, including proper POSIX/POSIX_STDIO handling |
| bsp/qemu-virt64-aarch64/applications/console.c | Removed BSP-specific console command implementation (now in common finsh module) |
Signed-off-by: GuEe-GUI <[email protected]>
|
@Rbb666 AI 相关要求已修改 |
拉取/合并请求描述:(PR description)
[
add 'console' command to config console, support 'set' option to change console device only.
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up