Security: SQL Injection Risk in Dynamic Query Construction#326
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The file `apps/web/e2e/scripts/get-magic-link-token.ts` constructs a SQL LIKE pattern by string concatenation: `value::text ILIKE ${'"email":"' + email + '"%'}`. While the `postgres` library uses parameterized queries for the main query, the LIKE pattern is built via string concatenation before being passed as a parameter. If `email` contains special characters, it could affect pattern matching behavior or cause unexpected query results.
Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: SQL Injection Risk in Dynamic Query Construction
Problem
Severity:
Medium| File:apps/web/e2e/scripts/get-magic-link-token.ts:L42The file
apps/web/e2e/scripts/get-magic-link-token.tsconstructs a SQL LIKE pattern by string concatenation:value::text ILIKE ${'"email":"' + email + '"%'}. While thepostgreslibrary uses parameterized queries for the main query, the LIKE pattern is built via string concatenation before being passed as a parameter. Ifemailcontains special characters, it could affect pattern matching behavior or cause unexpected query results.Solution
Sanitize or validate the email input before constructing the LIKE pattern. Consider using a more robust approach to query the JSON content, such as using PostgreSQL's JSON operators (e.g.,
value->>'email' = ${email}) instead of text matching on serialized JSON.Changes
apps/web/e2e/scripts/get-magic-link-token.ts(modified)