Refactor multi-section implementation#37
Merged
Conversation
… vihaco-parser-core, and left all publically usable structs in vihaco crate
…put> for ParsedModule
…text type parameter
Contributor
|
robpatterson13
marked this pull request as ready for review
July 8, 2026 18:39
kaihsin
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
vihaco-parser-core, with shared parsed-file/section tree types and stricter validation for section bounds, duplicate children, and child offsetsBytecodeContext/ProgramContextloading model with explicit global context traitsBytecodeGlobalContext,SstGlobalContext,SectionNameResolver, andNoContextLoadOwnBytecodeSection,LoadBytecodeSection,LoadOwnSstSection, andLoadSstSection, and replaceProgramLoaderwithProgramImageoverLocalModule(this means a one-to-one mapping betweenSectionViewandParsedModule#[composite]generated loading to route optional#[loadable]child sections, and removed#[header]and#[program](including program counter routing).globalas an implicit empty global context, and update docs/tests/examples for the new APIs