-
Notifications
You must be signed in to change notification settings - Fork 68
Fix warning due to timezone aware pandas index #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix warning due to timezone aware pandas index #531
Conversation
|
Maybe it would be easier to disallow timezone indexes entirely. There are some other issues that can pop up (for example when adding tz-aware data to non tz aware data) that lead to an error with numpy not understanding the datetime[ns, UTC] type when it tries to join the data |
FabianHofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great @RobbieKiwi ; any chance we can generalize to multi-dim case?
|
I added a check for the multi-dimensional case. |
Closes #451
Changes proposed in this Pull Request
Previously a timezone-aware datetime index coordinate would get converted into integers before comparison, resulting in a warning that the index does not match the pandas index.
Now there is special logic to handle this case that makes sure the coord is compared correctly.
Note this will only work in the 1D case
Checklist
doc.doc/release_notes.rstof the upcoming release is included.