Cow<[u8]> FromPyObject impl: allow any Sequence[int]
#5667
Merged
+17
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
commented
Dec 1, 2025
| /// If it is a `bytearray`, its contents will be copied to an owned `Cow`. | ||
| impl<'a, 'py> crate::conversion::FromPyObject<'a, 'py> for Cow<'a, [u8]> { | ||
| type Error = CastError<'a, 'py>; | ||
| type Error = PyErr; |
Contributor
Author
There was a problem hiding this comment.
Needed because conversion from arbitrary sequences can raise Python exceptions
Simplifies the type hint: bytes and bytearray are Sequence[int] Allows to drop INPUT_SEQUENCE_TYPE
davidhewitt
approved these changes
Dec 7, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, this seems like a good simplification to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the type hint:
bytesandbytearrayare extendingSequence[int]Allows to drop
INPUT_SEQUENCE_TYPEClose #5658