Skip to content

allow a "onresize" function to be passed for customized TableViews #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DRoppelt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow a "onresize" function to be passed for customized TableViews #295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ce5aa1
allow a "onresize" function to be passed that can be implemented alon…
DRoppelt Aug 12, 2025
e6bdca6
allow a "onresize" function to be passed that can be implemented alon…
DRoppelt Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/columnresizing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,23 @@ export type ColumnResizingOptions = {
view: EditorView,
) => NodeView)
| null;
/**
* an update trigger to update above View on resizing
*/
updateViewOnColumnResize?: UpdateViewOnColumnResize;
};

export interface UpdateViewOnColumnResize {
(
node: ProsemirrorNode,
colgroup: HTMLTableColElement,
table: HTMLTableElement,
defaultCellMinWidth: number,
overrideCol?: number,
overrideValue?: number,
): void
}

/**
* @public
*/
Expand All @@ -60,6 +75,14 @@ export function columnResizing({
defaultCellMinWidth = 100,
View = TableView,
lastColumnResizable = true,
updateViewOnColumnResize = (
node: ProsemirrorNode,
colgroup: HTMLTableColElement,
table: HTMLTableElement,
defaultCellMinWidth: number,
overrideCol?: number,
overrideValue?: number,
) => updateColumnsOnResize(node, colgroup, table, defaultCellMinWidth, overrideCol, overrideValue)
}: ColumnResizingOptions = {}): Plugin {
const plugin = new Plugin<ResizeState>({
key: columnResizingPluginKey,
Expand Down Expand Up @@ -94,7 +117,7 @@ export function columnResizing({
handleMouseLeave(view);
},
mousedown: (view, event) => {
handleMouseDown(view, event, cellMinWidth, defaultCellMinWidth);
handleMouseDown(view, event, cellMinWidth, defaultCellMinWidth, updateViewOnColumnResize);
},
},

Expand Down Expand Up @@ -195,6 +218,7 @@ function handleMouseDown(
event: MouseEvent,
cellMinWidth: number,
defaultCellMinWidth: number,
onColumnResizeViewUpdate: UpdateViewOnColumnResize,
): boolean {
if (!view.editable) return false;

Expand Down Expand Up @@ -239,6 +263,7 @@ function handleMouseDown(
pluginState.activeHandle,
dragged,
defaultCellMinWidth,
onColumnResizeViewUpdate,
);
}
}
Expand All @@ -248,6 +273,7 @@ function handleMouseDown(
pluginState.activeHandle,
width,
defaultCellMinWidth,
onColumnResizeViewUpdate,
);

win.addEventListener('mouseup', finish);
Expand Down Expand Up @@ -359,6 +385,7 @@ function displayColumnWidth(
cell: number,
width: number,
defaultCellMinWidth: number,
onColumnResizeViewUpdate: UpdateViewOnColumnResize,
): void {
const $cell = view.state.doc.resolve(cell);
const table = $cell.node(-1),
Expand All @@ -372,7 +399,7 @@ function displayColumnWidth(
dom = dom.parentNode;
}
if (!dom) return;
updateColumnsOnResize(
onColumnResizeViewUpdate(
table,
dom.firstChild as HTMLTableColElement,
dom as HTMLTableElement,
Expand Down