style: провести к стандарту Яндекс Практикума#37
Open
flykeeperB wants to merge 1 commit intoPraktikumJava:masterfrom
Open
style: провести к стандарту Яндекс Практикума#37flykeeperB wants to merge 1 commit intoPraktikumJava:masterfrom
flykeeperB wants to merge 1 commit intoPraktikumJava:masterfrom
Conversation
alisilakg
reviewed
Dec 11, 2022
alisilakg
left a comment
alisilakg
left a comment
There was a problem hiding this comment.
В целом, работа мне понравилась. Всё красиво и понятно. Так держать))))
| } | ||
|
|
||
| void runInterface() { | ||
| int period; |
There was a problem hiding this comment.
Я бы объявила переменные и сразу им присвоила значения из сканнера, или все переменные(period,action,amout) объявила бы, а потом уже присваивала значения, чтоб было единообразно
| } | ||
|
|
||
| double round(double value, int places) { | ||
| double ScaLe = Math.pow(10, places); |
There was a problem hiding this comment.
scale - переменная, лучше с маленькой буквы написать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.