Skip to content

ci: mark release approval Slack message#198

Merged
marandaneto merged 1 commit into
mainfrom
ci/release-approval-checkmark
Jul 2, 2026
Merged

ci: mark release approval Slack message#198
marandaneto merged 1 commit into
mainfrom
ci/release-approval-checkmark

Conversation

@marandaneto

Copy link
Copy Markdown
Member

💡 Motivation and Context

The PHP release workflow sends the shared notify-approval-needed Slack message, but unlike the other SDK release workflows it did not mark that Slack thread with a checkmark once the GitHub environment approval was granted.

This adds the same approved Slack reply/reaction step used by the other SDKs after the Release environment gate opens.

💚 How did you test it?

Parsed .github/workflows/release.yml successfully as YAML.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

A pi coding agent made this surgical workflow update at the user's request. The change mirrors the Slack approval acknowledgement pattern already present in other PostHog SDK release workflows and intentionally avoids adding a changeset because this is CI-only behavior.

@marandaneto marandaneto self-assigned this Jul 2, 2026
@marandaneto marandaneto marked this pull request as ready for review July 2, 2026 15:58
@marandaneto marandaneto requested a review from a team as a code owner July 2, 2026 15:58
@marandaneto marandaneto enabled auto-merge (squash) July 2, 2026 15:58
@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "ci: mark release approval Slack message" | Re-trigger Greptile

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

posthog-php Compliance Report

Date: 2026-07-02 15:59:30 UTC
Duration: 95303ms

✅ All Tests Passed!

46/46 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 11ms
Format Validation.Event Has Uuid 6ms
Format Validation.Event Has Lib Properties 5ms
Format Validation.Distinct Id Is String 6ms
Format Validation.Token Is Present 5ms
Format Validation.Custom Properties Preserved 6ms
Format Validation.Event Has Timestamp 6ms
Retry Behavior.Retries On 503 5314ms
Retry Behavior.Does Not Retry On 400 2010ms
Retry Behavior.Does Not Retry On 401 2009ms
Retry Behavior.Respects Retry After Header 8010ms
Retry Behavior.Implements Backoff 15728ms
Retry Behavior.Retries On 500 5115ms
Retry Behavior.Retries On 502 5114ms
Retry Behavior.Retries On 504 5114ms
Retry Behavior.Max Retries Respected 16528ms
Deduplication.Generates Unique Uuids 12ms
Deduplication.Preserves Uuid On Retry 5113ms
Deduplication.Preserves Uuid And Timestamp On Retry 10321ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 5116ms
Deduplication.No Duplicate Events In Batch 12ms
Deduplication.Different Events Have Different Uuids 7ms
Compression.Sends Gzip When Enabled 5ms
Batch Format.Uses Proper Batch Structure 6ms
Batch Format.Flush With No Events Sends Nothing 3ms
Batch Format.Multiple Events Batched Together 11ms
Error Handling.Does Not Retry On 403 2007ms
Error Handling.Does Not Retry On 413 2010ms
Error Handling.Retries On 408 5114ms

Feature_Flags Tests

17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 6ms
Request Payload.Flags Request Uses V2 Query Param 5ms
Request Payload.Flags Request Hits Flags Path Not Decide 5ms
Request Payload.Flags Request Omits Authorization Header 4ms
Request Payload.Token In Flags Body Matches Init 5ms
Request Payload.Groups Round Trip 4ms
Request Payload.Groups Default To Empty Object 5ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 5ms
Request Payload.Disable Geoip Omitted Defaults To False 4ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 5ms
Request Lifecycle.No Flags Request On Init Alone 2ms
Request Lifecycle.No Flags Request On Normal Capture 6ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 6ms
Request Lifecycle.Mock Response Value Is Returned To Caller 5ms
Retry Behavior.Retries Flags On 502 107ms
Retry Behavior.Retries Flags On 504 108ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 7ms

@marandaneto marandaneto merged commit 6e9b649 into main Jul 2, 2026
23 checks passed
@marandaneto marandaneto deleted the ci/release-approval-checkmark branch July 2, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants