Add chainable DiffDriveController #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henningkayser
force-pushed
the
chainable_diff_drive
branch
from
04e7fed to
339bf84
Compare
henningkayser
force-pushed
the
chainable_diff_drive
branch
from
339bf84 to
90e7bc5
Compare
Author
|
The Rolling and Iron ABI checks are failing because we are targeting the Humble version of the diff drive controller. There is no way to support Humble, Iron, and Rolling at the same time with this. |
Contributor
|
Fyi: Upstream diff_drive_controller with ros2_controllers is chainable from jazzy on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the chainable DiffDriveController POC from my fork into picknik_controllers.
Please don't squash merge this PR, it will be much easier to revert the PickNik prefixing if we choose to migrate this to ros2_controllers at some point.