Skip to content

Conversation

@christophfroehlich
Copy link
Collaborator

@christophfroehlich christophfroehlich commented Dec 6, 2025

I removed all linters from the testing stage, as we have a pre-commit config and CI job here.

Advantages:

  • Similar config for all packages
  • Splitting the linters from the remaining CI tests in a separate job, where they belong to
  • I removed the include order filtering in the clang-format setting to match cpplint. This is more of a religious question, I just got used to google code style.
  • ament_copyright failed now because of Remove invalid license template. ament/ament_lint#209
  • Used the same pre-commit job setting as in ros-controls repo (preinstalling ament linters), and the upload pre-commit patch did not work anymore anyways.

@christophfroehlich christophfroehlich marked this pull request as ready for review December 7, 2025 15:21
Copy link
Collaborator

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@christophfroehlich christophfroehlich merged commit 46f6123 into main Dec 22, 2025
8 of 9 checks passed
@christophfroehlich christophfroehlich deleted the rm/linters branch December 22, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants