feature(#13558): add copper golem state api #13561
Open
+78
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc94
reviewed
Jan 18, 2026
paper-server/src/main/java/org/bukkit/craftbukkit/entity/CraftCopperGolem.java
Outdated
Show resolved
Hide resolved
yannicklamprecht
force-pushed
the
issues/13558/copper-state-api
branch
from
6a066d1 to
8575594
Compare
Doc94
reviewed
Jan 18, 2026
paper-generator/src/main/java/io/papermc/generator/utils/SimpleEnumBridgeGenerator.java
Outdated
Show resolved
Hide resolved
yannicklamprecht
force-pushed
the
issues/13558/copper-state-api
branch
from
8575594 to
b3fd552
Compare
| DROPPING_NO_ITEM("dropping_no_item", 4); | ||
|
|
||
| - public static final Codec<CopperGolemState> CODEC = StringRepresentable.fromEnum(CopperGolemState::values); | ||
| + public static final StringRepresentable.EnumCodec<CopperGolemState> CODEC = StringRepresentable.fromEnum(CopperGolemState::values); // Paper - support copper golem state api mapping byName |
Contributor
Author
There was a problem hiding this comment.
@Doc94 Instead of modifying nms code should I just cast it to StringRepresentable.EnumCodec ?
Comment on lines
+147
to
+152
| @Override | ||
| protected EnumValue.Builder rewriteEnumValue(net.minecraft.world.entity.animal.golem.CopperGolemState state) { | ||
| final String name = Formatting.formatKeyAsField(state.getSerializedName()); | ||
| return EnumValue.builder(name).argument(quoted(state.getSerializedName())); | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
Is this part supposed to be exposed or is it only used for the conversion? can just do a.valueOf(b.name()) once it's generated. The javadocs of getId is at least a bit weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13558