Skip to content

Conversation

@cqulilujia
Copy link
Contributor

Motivation

重构XPU block_attention算子中的pos_emb_type参数,将pos_emb_type的赋值从框架下沉到自定义算子,增加算子的通用性,减少新模型的适配成本和出错风险。

@paddle-bot
Copy link

paddle-bot bot commented Dec 11, 2025

Thanks for your contribution!

@paddle-bot paddle-bot bot added the XPU label Dec 11, 2025
Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@c3aaa7e). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5511   +/-   ##
==========================================
  Coverage           ?   60.28%           
==========================================
  Files              ?      329           
  Lines              ?    41114           
  Branches           ?     6261           
==========================================
  Hits               ?    24785           
  Misses             ?    14440           
  Partials           ?     1889           
Flag Coverage Δ
GPU 60.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ddchenhao66 ddchenhao66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iosmers
Copy link
Collaborator

iosmers commented Dec 12, 2025

LGTM

@iosmers iosmers merged commit 888c4b9 into PaddlePaddle:develop Dec 12, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants