Add an internal function in ERC7913WebAuthnVerifier to allow disabling the UV check#6596
Add an internal function in ERC7913WebAuthnVerifier to allow disabling the UV check#6596Amxx wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 40231b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Walkthrough
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/slimy-pugs-shop.md:
- Line 5: Fix the typo in the changeset entry for ERC7913WebAuthnVerifier by
changing “overriden” to “overridden” in the descriptive text. Update the wording
only; keep the rest of the changeset content unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 7b77ff9d-04bb-4933-a598-bcbf3683aca0
📒 Files selected for processing (2)
.changeset/slimy-pugs-shop.mdcontracts/utils/cryptography/verifiers/ERC7913WebAuthnVerifier.sol
Today, people that want an ERC-7913 verifier that supports webauthn without the UV check have to write it from scratch. This change gives them the opportunity to inherit
ERC7913WebAuthnVerifierand disable the check by overriding_requireUV()An alternative option would be to have a
bool immutable internal _requireUV;and a constructor, but it would be breaking (adding a constructor to a contract that doesn't have one.PR Checklist
npx changeset add)