Skip to content

Add an internal function in ERC7913WebAuthnVerifier to allow disabling the UV check#6596

Open
Amxx wants to merge 4 commits into
OpenZeppelin:masterfrom
Amxx:verifier/web-authn-verifier-override-requireUV
Open

Add an internal function in ERC7913WebAuthnVerifier to allow disabling the UV check#6596
Amxx wants to merge 4 commits into
OpenZeppelin:masterfrom
Amxx:verifier/web-authn-verifier-override-requireUV

Conversation

@Amxx

@Amxx Amxx commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Today, people that want an ERC-7913 verifier that supports webauthn without the UV check have to write it from scratch. This change gives them the opportunity to inherit ERC7913WebAuthnVerifier and disable the check by overriding _requireUV()

An alternative option would be to have a bool immutable internal _requireUV; and a constructor, but it would be breaking (adding a constructor to a contract that doesn't have one.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@Amxx Amxx requested a review from ernestognw June 26, 2026 07:59
@Amxx Amxx requested a review from a team as a code owner June 26, 2026 07:59
@changeset-bot

changeset-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 40231b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx added this to the 5.7 milestone Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

ERC7913WebAuthnVerifier now passes _requireUV() into WebAuthn.verify, and it adds a new internal virtual _requireUV() hook that returns true. The changeset also records the openzeppelin-solidity patch and notes the UV-related verifier behavior.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding an internal hook in ERC7913WebAuthnVerifier to disable the UV check.
Description check ✅ Passed The description is directly related to the changeset and explains the UV-check override approach and rationale.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.changeset/slimy-pugs-shop.md:
- Line 5: Fix the typo in the changeset entry for ERC7913WebAuthnVerifier by
changing “overriden” to “overridden” in the descriptive text. Update the wording
only; keep the rest of the changeset content unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7b77ff9d-04bb-4933-a598-bcbf3683aca0

📥 Commits

Reviewing files that changed from the base of the PR and between c2c72f5 and f7f4651.

📒 Files selected for processing (2)
  • .changeset/slimy-pugs-shop.md
  • contracts/utils/cryptography/verifiers/ERC7913WebAuthnVerifier.sol

Comment thread .changeset/slimy-pugs-shop.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant