-
Notifications
You must be signed in to change notification settings - Fork 2
isometric tilemap rendering added #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @pankaj-bind, when you think you're done, please mention me at this PR. I'm considering joining forces to make it happen in issue #1. |
|
Hi @ggondim and @pankaj-bind! I reviewed PR #3 in detail. @pankaj-bind has built a really solid foundation here, the architecture is clean, the chunk system works well, and the documentation is Great work! I found some bugs that need fixing before merge: Critical Issues:
Missing Features: Code Quality: I'd love to collaborate with @pankaj-bind to fix these and complete the implementation. I can:
@pankaj-bind would you prefer I fork your branch and submit fixes as a PR to you, or should we coordinate on fixing these together? @ggondim given the additional scope, how would you like to structure the bounty? The MVP is 70% there, but these fixes will take another 8-10 hours to do properly. |
|
@SaurabhCodesAI let's coordinate on fixing these together |
|
@SaurabhCodesAI, that's an excellent outcome from the review. I can't precisely gauge the workload required for this, but I'm considering duplicating the bounty so that each of you receives the same amount. If you prefer, you can also suggest a new one following the README instructions. Just let me know. Additionally, I'm working on a new backlog/roadmap with more features. |
|
Hey @ggondim! Works for me, duplicating the bounty is fair. Let's do it. @pankaj-bind, here's the split: You handle:
I'll take:
You're building on your stuff, I'm handling the system integration. Sound good? Let me know if you want PRs to your branch or we work in parallel. @ggondim, my tasks are complete and tested in Godot 4.5.1. Demo video and final polish will come in the next phase to ensure we hit 100% of the README requirements. Happy to discuss the full scope, also curious about the roadmap you mentioned! |
|
Hey @pankaj-bind updated the task split above with your remaining items (animation hookup, code cleanup). Let's wrap this up! |
… support, chunk loading, undo/redo heights
ab8a2ab to
d9061b3
Compare
|
@SaurabhCodesAI You did an excellent job. |
|
Thanks @pankaj-bind! Great working with you. Let me know if you need any help with the cleanup. |
|
Hey @ggondim, everything looks good to me. @SaurabhCodesAI has done an excellent job. I believe this PR is now ready to be merged. |
|
@ggondim please review |
PR #2 I'm close to fulfilling all the requirements