-
Notifications
You must be signed in to change notification settings - Fork 73
Add Matomo tracking code via static JavaScript file #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: tjeerdijk <[email protected]>
Co-authored-by: tjeerdijk <[email protected]>
|
@copilot Can you add a file matomo.js similar as was done for piwik.js |
Co-authored-by: tjeerdijk <[email protected]>
|
@copilot can you keep the reference to piwik.js in conf.py. we will remove piwik tracking in a future PR |
Co-authored-by: tjeerdijk <[email protected]>
Updated Matomo Analytics tracking code to use new URL and site ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lintly has detected code quality issues in this pull request.
Added a comment explaining the purpose of the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lintly has detected code quality issues in this pull request.
Added installation of PyOpenMS after dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lintly has detected code quality issues in this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lintly has detected code quality issues in this pull request.
|
@copilot Can you leave .github/workflows/test-pr-sphinx.yml unchanged and run checks again? |
Co-authored-by: tjeerdijk <[email protected]>
tjeerdijk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thx copilot
Plan for Adding Matomo Tracking Code
Summary
Successfully added Matomo analytics tracking to the pyOpenMS documentation using a static JavaScript file approach, while keeping the existing piwik.js tracking.
✅ Created
docs/source/_static/matomo.jswith standard Matomo tracking code✅ Updated
docs/source/conf.pyto include bothpiwik.jsandmatomo.jsinhtml_js_files✅ Reverted
.github/workflows/test-pr-sphinx.ymlto its original state✅ Verified both tracking codes are properly included in generated HTML
✅ Tested with Sphinx build - both files correctly loaded and copied to output
Technical Details
docs/source/_static/matomo.js(13 lines)docs/source/conf.py(includes bothpiwik.jsandmatomo.js).github/workflows/test-pr-sphinx.yml(kept unchanged as requested)https://openms-web.containers.piwik.pro/977a289b-8290-4244-920c-847eb3da6b09piwik.jsimplementationCurrent State
Both
piwik.jsandmatomo.jsare now included in the documentation. The piwik.js tracking will be removed in a future PR as planned by the team.Impact
Both Matomo tracking implementations will be included on all documentation pages when built by Sphinx. This allows for a transition period before removing the old piwik.js tracking.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.