Sea Level Density overhaul -> Requires OpenMDAO bugfix#1233
Merged
Conversation
ehariton
reviewed
Jul 15, 2026
Kenneth-T-Moore
marked this pull request as ready for review
July 16, 2026 17:22
ehariton
reviewed
Jul 17, 2026
| prob.set_val( | ||
| Dynamic.Atmosphere.DENSITY, | ||
| np.array([1.0001, 1.0001, 0.4482]) * RHO_SEA_LEVEL_ENGLISH, | ||
| np.array([1.0001, 1.0001, 0.4482]) * 0.0023769, |
Contributor
There was a problem hiding this comment.
could use a note here saying 0.002 is RHO Sea Level Density in slugs / etc
ehariton
reviewed
Jul 17, 2026
| default_value=0, | ||
| ) | ||
|
|
||
| add_meta_data( |
Contributor
There was a problem hiding this comment.
Do you need to set Mission.SEA_LEVEL_DENSITY in preprocessor.py if the user hasn't called it out in the CSV? I know with Mission.GRAVITY we did have to do this.
Member
Author
There was a problem hiding this comment.
Discussed with Eliot, but yeah, this is there already.
ehariton
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the RHO_SEA_LEVEL_ENGLISH and RHO_SEA_LEVEL_SI constants that were used in various places and had different values.
Mission.SEA_LEVEL_DENSITY. This option will be set automatically by the preprocessor if it isn't specified in the csv file. Like gravity, the preprocessor will compute it from the atmosphere model that is chosen.In 2DOF, thee VRot execcomp, which computes the speed at which rotation starts, has been moved into the groundroll phase along with its constraint.
ExplicitComponentin preparation for the gravity overhaul part 4.This work has exposed a bug in OpenMDAO when connecting an input to another input. This requires a bugfix that is currently a PR, but will soon be merged, and will eventually become part of a release. The CI has been configured to load OpenMDAO from github in all workflows for now.
Related Issues
Backwards incompatibilities
None
AI Usage
None