Battery service refactor#698
Merged
tullom merged 2 commits intoOpenDevicePartnership:v0.2.0from Feb 3, 2026
Merged
Conversation
tullom
requested review from
asasine,
gjpmsft,
madeleyneVaca and
williampMSFT
RobertZ2011
requested changes
Feb 2, 2026
tullom
force-pushed
the
battery-service-refactor
branch
from
81cac7a to
7deb2fb
Compare
RobertZ2011
approved these changes
Feb 2, 2026
kurtjd
approved these changes
Feb 3, 2026
thdesil
approved these changes
Feb 3, 2026
- Remove static `SERVICE` in battery service - Replace battery service free functions with methods on `Service` - Add battery `Device` as an argument to `battery_service::task()` to ensure all devices are registered before the state machine starts - Update examples
`process_event` public
tullom
force-pushed
the
battery-service-refactor
branch
from
7deb2fb to
9f52ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SERVICEin battery serviceServiceDeviceas an argument tobattery_service::task()to ensure all devices are registered before the state machine starts