Fix Jackson Serialization of additionalProperties on java and jaxrs-spec #22366
+94
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
blaghed
force-pushed
the
bugfix/issue22345
branch
from
2d96e0e to
3a80c20
Compare
wing328
reviewed
Dec 11, 2025
| import com.fasterxml.jackson.annotation.JsonFormat; | ||
| {{/additionalPropertiesType}} | ||
| {{/model}} | ||
| {{/models}} |
Member
There was a problem hiding this comment.
thanks for the PR
if there more than 1 model in the spec, would this result in duplicated imports?
Author
There was a problem hiding this comment.
It does, yes. But I couldn't find that to be much of an issue.
Member
There was a problem hiding this comment.
did you test this fix locally to confirm it works for your use cases?
did you follow step 3 to update the samples?
Member
There was a problem hiding this comment.
please use -first (or -last) to only show the import once only
ref:
openapi-generator/docs/templating.md
Line 992 in 7ccd039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22345