Conversation
snoweuph
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
snoweuph
force-pushed
the
feature/gaslighting
branch
2 times, most recently
from
f849348 to
cd174c1
Compare
|
rebased |
snoweuph
force-pushed
the
feature/gaslighting
branch
from
cd174c1 to
b74e2f4
Compare
|
rebased |
snoweuph
force-pushed
the
feature/gaslighting
branch
from
b74e2f4 to
290a763
Compare
|
rebased |
| in { | ||
| options.vim.fun = { | ||
| syntax-gaslighting = { | ||
| enable = mkEnableOption "Thats no even a real option, you're crazy."; |
There was a problem hiding this comment.
We should be more descriptive in generated documentation. Not everyone will get the joke here.
Also rather than than vim.fun this could probably go under vim.visuals since cellular-automata, a similar "fun" plugin, is already in there. Given syntax-gaslighting is just syntax highlighting (with diagnostic messages), visuals is suitable imho. Though as I've said before, this might be a good opportunity to stop categorizing plugins (due to the conflicts and the difficulty to categorize all plugins) and start using vim.plugins.<name> instead. Let's hear what @horriblename and @Soliprem think about this.
There was a problem hiding this comment.
Yea this can go into visuals
In regards to removing categories, I'm neutral on that front
I don't really think removing categories is absolutely necessary, I think chucking everything we can't categorize under "utilities" or "miscellaneous" is fine + I don't particularly like breaking changes.
If we do go through with abolishing the categories, I will say they are nice for discovering plugins you don't know about, or finding alternatives, so putting up an "index" page of sorts for all plugins and giving them category tags would be nice - should make the mini family more discoverable by category. In the end this might not be necessary, there are other sites dedicated to indexing plugins already, so anything we do in this regard is just a nice-to-have
There was a problem hiding this comment.
I will say they are nice for discovering plugins you don't know about, or finding alternatives, so putting up an "index" page of sorts for all plugins and giving them category tags would be nice - should make the mini family more discoverable by category. In the end this might not be necessary, there are other sites dedicated to indexing plugins already, so anything we do in this regard is just a nice-to-have
There might be other sides for discoverability, but none that also have info about whats packaged in nvf.
I like the idea of having a way to tag related stuff, and just move most plugins to vim.plugins, but I would still keep some namespaces like vim.languages
@NotAShelf I will update this to go into visuals for now. Is there an Issue/Discussion about the abolishing of namespaces yet?
I would like to split this discussion from the MR
snoweuph
force-pushed
the
feature/gaslighting
branch
from
290a763 to
e6e7f93
Compare
3 participants
You're just crazy
(#1377)
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.