Skip to content

Conversation

@dramforever
Copy link
Contributor

@dramforever dramforever commented Dec 5, 2025

Fix for the missing error message on an invalid SRI hash. Repro from K900:

nix build --expr 'let pkgs = import <nixpkgs> {}; in pkgs.fetchurl { url = "ohno"; hash = "sha256-ohno"; }' --impure

Patch is from NixOS/nix#14240, which is on 2.31-maintenance but not in a release yet.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. labels Dec 5, 2025
@dramforever dramforever added the backport release-25.11 Backport PR automatically label Dec 5, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 5, 2025
@Ericson2314 Ericson2314 added this pull request to the merge queue Dec 5, 2025
Merged via the queue into NixOS:staging-nixos with commit 2d6767d Dec 5, 2025
32 of 36 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 5, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 5, 2025

Successfully created backport PR for release-25.11:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 5, 2025
@fabianhjr
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 468208
Commit: 4f6df2ad2fb576e6d37f08aa977e26ff95ed18c1


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • tests.pkg-config.defaultPkgConfigPackages.tests-combined
⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 4 packages failed to build:
  • nixStatic
  • nixStatic.dev
  • nixStatic.doc
  • nixStatic.man
✅ 1 test built:
  • nixosTests.simple
✅ 146 packages built:
  • appvm
  • bundix
  • cabal2nix
  • cached-nix-shell
  • chirpstack-concentratord
  • colmena
  • comma
  • common-updater-scripts
  • corto
  • crate2nix
  • crush
  • dhall-nix
  • dhall-nixpkgs
  • disko
  • dub-to-nix
  • dydisnix
  • fusionInventory
  • gcalcli
  • gcalcli.dist
  • gclient2nix
  • glpi-agent
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.dhall-nix
  • haskellPackages.dhall-nix.doc
  • haskellPackages.dhall-nixpkgs
  • haskellPackages.dhall-nixpkgs.doc
  • haskellPackages.hnix
  • haskellPackages.hnix.doc
  • haskellPackages.niv
  • haskellPackages.niv.bin
  • haskellPackages.niv.data
  • haskellPackages.niv.doc
  • haskellPackages.nix-paths
  • haskellPackages.nix-paths.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • home-manager
  • kcl
  • libnixxml
  • localtunnel
  • lua51Packages.luarocks-nix
  • luarocks-nix (luaPackages.luarocks-nix)
  • lua53Packages.luarocks-nix
  • lua54Packages.luarocks-nix
  • luajitPackages.luarocks-nix
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • lux-cli
  • mdwatch
  • meshlab
  • mlv-app
  • nil
  • nim_lk
  • niv (niv.bin, niv.data)
  • nix (nixVersions.nix_2_31, nixVersions.stable)
  • nix-bundle
  • nix-direnv
  • nix-forecast
  • nix-index
  • nix-init
  • nix-pin
  • nix-prefetch
  • nix-prefetch-docker
  • nix-prefetch-github (python313Packages.nix-prefetch-github)
  • nix-prefetch-github.dist (python313Packages.nix-prefetch-github.dist)
  • nix-prefetch-github.man (python313Packages.nix-prefetch-github.man)
  • nix-required-mounts
  • nix-required-mounts.dist
  • nix-serve
  • nix-template
  • nix-update
  • nix-update.dist
  • nix-visualize
  • nix-visualize.dist
  • nix-web
  • nix.dev (nixVersions.nix_2_31.dev, nixVersions.stable.dev)
  • nix.doc (nixVersions.nix_2_31.doc, nixVersions.stable.doc)
  • nix.man (nixVersions.nix_2_31.man, nixVersions.stable.man)
  • nixci
  • nixos-anywhere
  • nixos-generators
  • nixos-option
  • nixos-rebuild
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist
  • nixos-shell
  • nixpkgs-hammering
  • nixpkgs-manual
  • nixpkgs-review
  • nixpkgs-review.dist
  • nixpkgs-reviewFull
  • nixpkgs-reviewFull.dist
  • nixseparatedebuginfod2
  • nixtract
  • node2nix (nodePackages.node2nix)
  • nodePackages_latest.node2nix
  • nps
  • nuget-to-json
  • nurl
  • nvfetcher
  • python312Packages.nix-kernel
  • python312Packages.nix-kernel.dist
  • python312Packages.nix-prefetch-github
  • python312Packages.nix-prefetch-github.dist
  • python312Packages.nix-prefetch-github.man
  • python312Packages.pymeshlab (python313Packages.pymeshlab)
  • python313Packages.nix-kernel
  • python313Packages.nix-kernel.dist
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • ragenix
  • sbomnix
  • sbomnix.dist
  • sus-compiler
  • swiftpm2nix (swiftPackages.swiftpm2nix)
  • terranix
  • tests.devShellTools.nixos
  • tests.dhall.generateDhallDirectoryPackage
  • tests.fetchgit.cached-prefetch-avoids-fetch
  • tests.fetchgit.prefetch-git-no-add-path
  • tests.pkg-config.defaultPkgConfigPackages.nix-cmd
  • tests.pkg-config.defaultPkgConfigPackages.nix-expr
  • tests.pkg-config.defaultPkgConfigPackages.nix-main
  • tests.pkg-config.defaultPkgConfigPackages.nix-store
  • tests.pkgs-lib
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example (tests.testers.runNixOSTest-extendNixOS)
  • tests.trivial-builders.references
  • update-nix-fetchgit
  • update-python-libraries
  • vclab-nexus
  • vclab-nexus.bin
  • vimPluginsUpdater
  • vulnix
  • vulnix.dist
  • vulnix.doc
  • vulnix.man
  • wp4nix
  • xosd-xft
  • zon2nix

@vcunat
Copy link
Member

vcunat commented Dec 8, 2025

I think this is what broke nix build on *-darwin, e.g. see
https://hydra.nixos.org/build/316056678

@vcunat
Copy link
Member

vcunat commented Dec 8, 2025

Yes, I just confirmed locally that reverting this PR on nixpkgs master would fix that build failure (on aarch64-darwin).

@dramforever
Copy link
Contributor Author

Is this possibly filesystem dependent? I can't reproduce the problem on the nix-community darwin builder

@Ericson2314
Copy link
Member

Maybe this is a matter of making sure we also update the test suite?

@dramforever
Copy link
Contributor Author

It shouldn't be a test suite problem, because it clearly builds on Linux, and on Darwin with sandbox...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants