-
-
Notifications
You must be signed in to change notification settings - Fork 17.4k
nixVersions.nix_2_31: Add patch for SRI hash formatting fix #468208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixVersions.nix_2_31: Add patch for SRI hash formatting fix #468208
Conversation
2d6767d
|
Successfully created backport PR for |
|
|
I think this is what broke |
|
Yes, I just confirmed locally that reverting this PR on nixpkgs master would fix that build failure (on aarch64-darwin). |
|
Is this possibly filesystem dependent? I can't reproduce the problem on the nix-community darwin builder |
|
Maybe this is a matter of making sure we also update the test suite? |
|
It shouldn't be a test suite problem, because it clearly builds on Linux, and on Darwin with sandbox... |
Fix for the missing error message on an invalid SRI hash. Repro from K900:
Patch is from NixOS/nix#14240, which is on 2.31-maintenance but not in a release yet.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.