fix: permissions sync #1539
Open
fix: permissions sync #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out permissions are hardcoded to "rwm" so they are synced (because not specifying anything ends up as setting rwm in the generated oci spec) but if someone ever changes rwm to sth else in the call to DeviceFromPath, it won't be effective Signed-off-by: Raphael Glon <[email protected]>
oOraph
force-pushed
the
sync_cg_permissions
branch
from
05a7b71 to
e54a999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out permissions are hardcoded to "rwm" so they are synced (because not specifying anything ends up as setting rwm in the generated oci spec) but if someone ever changes rwm to sth else in the call to DeviceFromPath, it won't be effective