Added Special puck option for FMX #420
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request introduces a "special mount" mode feature to the FMX beamline application, allowing users to toggle between standard dewar puck setup and a special puck configuration. The changes enable dynamic switching of puck display configurations and robot control behavior based on the selected mode.
- Added UI radio buttons for selecting between "Special Puck" and "Dewar Puck" modes
- Modified dewar tree view to display only one puck and sector when special mount mode is enabled
- Updated robot control logic to skip gripper parking in special mount mode
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| gui/control_main.py | Added radio button controls for puck type selection and toggle_special_puck method to handle configuration switching |
| gui/dewar_tree.py | Modified refreshTreeDewarView to dynamically adjust puck/sector display based on special_mount_enabled configuration, added hard_refresh parameter |
| daq_lib.py | Updated unmountCold to conditionally skip gripper parking when special mount mode is active |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a "special mount" mode in the application, allowing users to toggle between a standard dewar puck setup and a special puck configuration. The changes include UI updates to select the puck type, logic to handle the configuration switch, and adjustments to the dewar tree view to reflect the selected mode.
User Interface Enhancements:
gui/control_main.py)toggle_special_puckmethod to update the configuration and trigger a hard refresh of the dewar tree view when the puck type is changed. (gui/control_main.py)Dewar Tree View Adjustments:
refreshTreeDewarViewmethod to show only one puck and sector when "special mount" mode is enabled, otherwise using the standard configuration. (gui/dewar_tree.py)refreshTreeDewarView, which clears the model before updating, ensuring the view accurately reflects the current configuration. (gui/dewar_tree.py)Robot Control Logic:
unmountColdfunction to only park the robot gripper if the robot is online and "special mount" mode is not enabled, preventing unnecessary actions in special mode. (daq_lib.py)