Removed unused functions from daq_macros #413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request removes several unused functions from daq_macros.py and refactors the runRasterScan function to use a parameter dictionary instead of an if-elif chain.
Changes:
- Removed 9 functions:
rasterWait,vectorHoldWait,vectorProceed,generateGridMapFine,defineTiledRaster,collectSpec,zebraArm,zebraWaitOld, andzebraWaitDownload - Refactored
runRasterScanto use a params dictionary for predefined raster types - Removed help references to deleted functions in
lsdcHelp
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2334
to
+2337
| rasterReqID = defineRectRaster(currentRequest, | ||
| selected_params["width"], | ||
| selected_params["height"], | ||
| selected_params["step_size"]) |
There was a problem hiding this comment.
Bug: For custom raster types, the original code added step_size to both width and height when calling defineRectRaster (width+step_size, height+step_size). The refactored code uses width and height directly without this adjustment, which will produce a raster that is one step smaller in each dimension than intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed more unused functions from daq_macros