-
Notifications
You must be signed in to change notification settings - Fork 1
[PRMP-775] Implement download success page #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamwhitingnhs
wants to merge
1
commit into
main
Choose a base branch
from
PRMP-775
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+181
−9
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
app/src/pages/downloadCompletePage/DownloadCompletePage.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import { buildPatientDetails } from '../../helpers/test/testBuilders'; | ||
| import { render, screen } from '@testing-library/react'; | ||
| import { runAxeTest } from '../../helpers/test/axeTestHelper'; | ||
| import { afterEach, beforeEach, describe, expect, it, vi, Mock } from 'vitest'; | ||
| import DownloadCompletePage from './DownloadCompletePage'; | ||
| import userEvent from '@testing-library/user-event'; | ||
| import { routes } from '../../types/generic/routes'; | ||
| import usePatient from '../../helpers/hooks/usePatient'; | ||
|
|
||
| vi.mock('../../helpers/hooks/usePatient'); | ||
|
|
||
| const mockedUseNavigate = vi.fn(); | ||
| const mockUsePatient = usePatient as Mock; | ||
|
|
||
| vi.mock('react-router-dom', () => ({ | ||
| useNavigate: () => mockedUseNavigate, | ||
| })); | ||
|
|
||
| describe('DownloadCompletePage', () => { | ||
| const mockPatient = buildPatientDetails(); | ||
|
|
||
| beforeEach(() => { | ||
| import.meta.env.VITE_ENVIRONMENT = 'vitest'; | ||
| mockUsePatient.mockReturnValue(mockPatient); | ||
| }); | ||
| afterEach(() => { | ||
| vi.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('renders the download complete screen', () => { | ||
| render(<DownloadCompletePage />); | ||
|
|
||
| expect(screen.getByTestId('page-title')).toBeInTheDocument(); | ||
| expect( | ||
| screen.getByText(`Patient name: ${mockPatient.familyName}, ${mockPatient.givenName}`), | ||
| ).toBeInTheDocument(); | ||
| expect(screen.getByText('Your responsibilities with this record')).toBeInTheDocument(); | ||
| expect( | ||
| screen.getByText('Follow the Record Management Code of Practice'), | ||
| ).toBeInTheDocument(); | ||
| expect( | ||
| screen.getByRole('button', { | ||
| name: 'Go to home', | ||
| }), | ||
| ).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('navigates to the home screen when go to home is clicked', async () => { | ||
| render(<DownloadCompletePage />); | ||
|
|
||
| await userEvent.click(screen.getByRole('button', {name: 'Go to home'})); | ||
|
|
||
| expect(mockedUseNavigate).toHaveBeenCalledWith(routes.HOME); | ||
| }); | ||
|
|
||
| it('navigates to the home screen if patient details are undefined', async () => { | ||
| mockUsePatient.mockReturnValue(undefined); | ||
| render(<DownloadCompletePage />); | ||
|
|
||
| expect(mockedUseNavigate).toHaveBeenCalledWith(routes.HOME); | ||
| }); | ||
|
|
||
| describe('Accessibility', () => { | ||
| it('passes accessibility checks', async () => { | ||
| render(<DownloadCompletePage />); | ||
| const results = await runAxeTest(document.body); | ||
| expect(results).toHaveNoViolations(); | ||
| }); | ||
| }); | ||
| }); |
68 changes: 68 additions & 0 deletions
68
app/src/pages/downloadCompletePage/DownloadCompletePage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import React from 'react'; | ||
| import { Button } from 'nhsuk-react-components'; | ||
| import useTitle from '../../helpers/hooks/useTitle'; | ||
| import { useNavigate } from 'react-router-dom'; | ||
| import { routes } from '../../types/generic/routes'; | ||
| import usePatient from '../../helpers/hooks/usePatient'; | ||
| import { formatNhsNumber } from '../../helpers/utils/formatNhsNumber'; | ||
| import { getFormattedDateFromString } from '../../helpers/utils/formatDate'; | ||
| import { getFormattedPatientFullName } from '../../helpers/utils/formatPatientFullName'; | ||
|
|
||
| const DownloadCompletePage = (): React.JSX.Element => { | ||
| const navigate = useNavigate(); | ||
| const patient = usePatient(); | ||
|
|
||
| const pageHeader = 'Download complete'; | ||
| useTitle({ pageTitle: pageHeader }); | ||
|
|
||
| if (!patient) { | ||
| navigate(routes.HOME); | ||
| return <></>; | ||
| } | ||
|
|
||
| return ( | ||
| <div className="document_download-complete"> | ||
| <div className="nhsuk-panel" data-testid="download-complete-card"> | ||
| <h1 data-testid="page-title" className="nhsuk-panel__title"> | ||
| Download complete | ||
| </h1> | ||
| <br /> | ||
| <div className="nhsuk-panel__body"> | ||
| <strong data-testid="patient-name">Patient name: {getFormattedPatientFullName(patient)}</strong> | ||
| <br /> | ||
| <span data-testid="nhs-number">NHS number: {formatNhsNumber(patient.nhsNumber)}</span> | ||
| <br /> | ||
| <span data-testid="dob">Date of birth: {getFormattedDateFromString(patient.birthDate)}</span> | ||
| </div> | ||
| </div> | ||
|
|
||
| <h2 className="nhsuk-heading-l">Your responsibilities with this record</h2> | ||
| <p> | ||
| Everyone in a health and care organisation is responsible for managing records | ||
| appropriately. It is important all general practice staff understand their | ||
| responsibilities for creating, maintaining, and disposing of records appropriately. | ||
| </p> | ||
|
|
||
| <h3 className="nhsuk-heading-m">Follow the Record Management Code of Practice</h3> | ||
| <p> | ||
| The{' '} | ||
| <a href="https://transform.england.nhs.uk/information-governance/guidance/records-management-code"> | ||
| Record Management Code of Practice | ||
| </a>{' '} | ||
| provides a framework for consistent and effective records management, based on | ||
| established standards. | ||
| </p> | ||
|
|
||
| <Button | ||
| data-testid="go-to-home-button" | ||
| onClick={(): void => { | ||
| navigate(routes.HOME); | ||
| }} | ||
| > | ||
| Go to home | ||
| </Button> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default DownloadCompletePage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.