[PRMP-1227] Bulk upload metadata processor to review SQS #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robg-test
had a problem deploying
to
development
GitHub Actions
Failure
robg-test
had a problem deploying
to
development
GitHub Actions
Failure
robg-test
had a problem deploying
to
development
GitHub Actions
Failure
| self.dynamo_repository.write_report_upload_to_dynamo( | ||
| failed_entry, UploadStatus.FAILED, str(error) | ||
| ) | ||
| failed_files[(nhs_number, ods_code)].append(failed_file) |
Contributor
There was a problem hiding this comment.
does order matter here? would we still want to append to failed files even if writing to dynamo for reporting fails
do we handle this failure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: PRMP-1227
Description
document uploads that fail demographic or business validation to be automatically sent to the Review Queue
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)Deploy - Sandbox- workflow run - 21133711872SANDBOX Full- Deploy feature branch to sandbox- workflow run - 21144523589