Open
Conversation
681b02c to
04e3229
Compare
Collaborator
Author
|
Closes #10 |
Open
c69f43c to
ffc02dd
Compare
ffc02dd to
0bec4ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to mimic the already existing style, but some parts were kinda inconsistent so I tried to do what I could.
I did not commit some formatted files because clang format kinda messed too much with them. Those files are:
config.cppandrecomp_input.h. clang format really doesn't like theNLOHMANN_JSON_SERIALIZE_ENUMmacrorecomp.h. Messes with multine macros and therecomp_contextstruct.euc-jp.cpp,rsp_vu.handrsp_vu_impl.h. Those files come from other places so I thought it would be better to left them untouched.I did not add a clang tidy file yet because currently the repo doesn't build yet.
Feel free to be as nitpicky as you want.