support channel_axis in _get_batch #1399
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, congrats on this amazing project, we've been using it successfully to segment large microscopy data.
Unforunately, I have encountered a bug trying to use
cellpose.train.train_segwithout loading all the files in memory, eg:The issue seems to be that
_get_batchreceives achannel_axiskwarg (see here) that it cannot handle.This simple patch fixes our usecase. Sorry for not adding extra tests, I'm not fully familiar with how the test suite is organized and couldn't understand how to add one, but any test that uses
load_files = Falseshould do it.