-
Notifications
You must be signed in to change notification settings - Fork 0
Initial SSR Migration #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,1801 @@ | |||
| openapi: 3.0.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this file be obtained from the mobiity-feed-api project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's copy and pasted from the mobiity-feed-api repo manually. It's one of the drawbacks of separating the repos. For the fastest fix this is it. Maybe we can think of a better long term solution ex: publishing a github asset and having the frontend consume it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that the PR is big enough as it is.
But I would suggest sometimes in the future maybe to get the file directly from git: https://github.com/MobilityData/mobility-feed-api/blob/main/docs/DatabaseCatalogAPI.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I agree, for that to happen we would have to publish some sort of asset. I'll make a follow up ticket
This PR introduces the migration to a SSR application using NextJs. For this PR, the Feed Detail Page (partially) and the About page were made server components as a proof of concept. This PR is not ready for PROD but as a great benchmark to keep development on SSR.
High Level Changes
Important follow up tasks
Future Improvements
Developer Tooling & Configuration:
.eslintrc.json)jest.config.ts)babel.config.js)vercel-react-best-practicesskills to improve copilot Agent code + reviewTesting & E2E Updates:
NEXT_PUBLIC_*), updated test routes to match Next.js routing, and improved test reliability with more robust selectors and timeouts. (cypress.config.ts,cypress/e2e/addFeedForm.cy.ts,cypress/e2e/feeds.cy.ts,cypress/support/commands.ts) [1] [2] [3] [4] [5] [6] [7]cypress/fixtures/gtfs_feed_test-516.json)Documentation Improvements:
README.mdto reflect the migration to Next.js, updated environment variable instructions, added new scripts, and documented API type generation and E2E testing workflows. (README.md) [1] [2] [3]These changes collectively modernize the project, streamline development and deployment, and ensure tests and documentation are aligned with the new Next.js architecture.