Skip to content

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Dec 26, 2025

Change Summary

Ruff is used in Data.Rentgen and Horizon, let's use it in SyncMaster as well.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Dec 26, 2025
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Dec 26, 2025
@dolfinus dolfinus force-pushed the feature/switch-to-ruff branch 6 times, most recently from 2f37011 to 9199768 Compare December 26, 2025 14:48
@dolfinus dolfinus changed the title Replace flake8 with ruff Switch from flake8 to ruff Dec 26, 2025
@dolfinus dolfinus force-pushed the feature/switch-to-ruff branch 6 times, most recently from 9652cb0 to 79ccff5 Compare December 26, 2025 16:55
@dolfinus dolfinus force-pushed the feature/switch-to-ruff branch from 79ccff5 to 96cba64 Compare December 26, 2025 16:59
@dolfinus dolfinus marked this pull request as ready for review December 26, 2025 17:05
@github-actions
Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
syncmaster/db/repositories
   base.py67395%34, 65, 75
   connection.py651084%83–84, 105–106, 114–115, 136, 138, 140, 143
   group.py1451093%162–163, 199, 249–250, 379–382, 390
   run.py62887%66–67, 74–75, 133–136
   search.py43295%36, 52
   transfer.py911484%105–106, 145–146, 183–184, 192–193, 230, 232, 238, 241, 244, 249
   user.py501472%40–41, 51–56, 82–83, 88, 90–91, 93
syncmaster/dto
   transfers.py114298%94–95
syncmaster/scheduler
   transfer_job_manager.py581181%53–54, 56, 60, 63–64, 66–68, 89–90
syncmaster/schemas/v1/connections
   iceberg.py48197%82
syncmaster/server
   handler.py1572584%57, 62, 70, 72, 76, 81, 91, 116, 122–124, 214–216, 230–231, 245–246, 319–321, 333–336
syncmaster/server/middlewares
   openapi.py502452%19–21, 23–25, 27, 31–32, 34, 50, 56–57, 61–65, 76, 80–84
syncmaster/server/providers/auth
   dummy_provider.py642757%29–30, 57–59, 61–66, 68–71, 73–75, 82–83, 87, 92, 102–104, 113, 117
   keycloak_provider.py892077%29–31, 67, 83–85, 116–118, 121–122, 129–130, 159–160, 164–167
   oauth2_gateway_provider.py581770%26–28, 52–54, 58–61, 72–73, 83–84, 102, 114, 120
syncmaster/server/services
   get_user.py31390%47, 57–58
syncmaster/worker
   controller.py92198%263
   spark.py52296%79–80
syncmaster/worker/handlers/file
   local_df.py65296%51, 55
   remote_df.py27292%32, 36
TOTAL511732093% 

@dolfinus dolfinus merged commit 2155bf1 into develop Dec 26, 2025
24 checks passed
@dolfinus dolfinus deleted the feature/switch-to-ruff branch December 26, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants