Open
Conversation
Owner
This is the biggest problem. In general, the way ISO files are searched for is very slow and should be changed. I didn’t expect the project to grow this much. It was meant to be a temporary solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds detection of ISOs in /ISOs on any partition of the MultiOS-USB device. Useful if the user wants a separate partition to boot large ISO files like Ubuntu or Windows from a partition with a different filesystem that is supported by the ISO environments.
I have tested the following to check if it works as expected:
In many of the config files a parameter has been added to the submenus, to set
iso_pathto a relative path (/ISOs/distro.iso) instead of an absolute path (like(hd1,gpt2)/ISOs/distro.iso) that only GRUB can parse.Potential downsides:
($dev,*)it could be that with more partitions the search/detection of ISOs will take longer. Perhaps a better solution would be to run a for loop for all devices from the main grub cfg.