Fix introspection source index create_sqls
#34812
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
force-pushed
the
index-sql-fix-id
branch
from
f58e5bc to
e6f22c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://materializeinc.slack.com/archives/CTESPM7FU/p1769174310567589?thread_ts=1769158893.295609&cid=CTESPM7FU
Nightly:
Draft, because I'm wondering whether the timeouts in the first Nightly run can possibly be caused by this PR slowing things down by
parse_iteminvolving more work than what we did before. Seems unlikely, because the modified code runs only at cluster creation (I think), but I'll need to think about it.