Skip to content

Conversation

@asinghvi17
Copy link
Member

This way throttling only happens in an interactive context.

This way throttling only happens in an interactive context.
@lazarusA
Copy link
Collaborator

lazarusA commented Jul 22, 2025

I cannot tell the difference on the recorded animation (I compared the one on dev to this one), however, something else catch my eye, in this PR (left) the tiles are more opaque than the ones in dev (right), did something changed with Shading? (or maybe is just me 😄 ).

Screenshot 2025-07-22 at 16 33 25

@asinghvi17
Copy link
Member Author

Hmm could be they are more detailed?

But I will create a test case and put it up

@lazarusA
Copy link
Collaborator

lazarusA commented Jul 22, 2025

Also here:

Screenshot 2025-07-22 at 16 42 06

This might more a makie thing change ? color handling is different, even for letters, and maybe nothing to do from our side.

@SimonDanisch
Copy link
Member

I have a hard time seeing the differences, but the text looking "bolder" is in the range of visual changes that v0.24 brought with it.
The right looks a bit sharper here right?
image
image
I hope the right one is v0.24? Or is this this PR vs Tyler master with the same makie version?

@lazarusA
Copy link
Collaborator

is this this PR vs Tyler master with the same makie version. (there should not be any differences, I'm lost now)

@asinghvi17
Copy link
Member Author

asinghvi17 commented Jul 22, 2025

In the images from both docs they have an RMSE of 0...there is no difference. I checked with imagemagick.

But I just realized that the tile loading code is itself asynchronous, so this makes no difference. We should add a callback on each OneTimeRenderTick that forces wait(m) before the rendering happens. That should be a kwarg to Map and universal to all axes. This is probably still needed for that though because it triggers the tile recomputation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants